imback82 commented on a change in pull request #27243: [SPARK-30535][SQL]
Migrate ALTER TABLE commands to the new framework
URL: https://github.com/apache/spark/pull/27243#discussion_r368368957
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -514,6 +436,33 @@ class ResolveSessionCatalog(
parseSessionCatalogFunctionIdentifier("CREATE FUNCTION", catalog,
ident)
CreateFunctionCommand(database, function, className, resources, isTemp,
ignoreIfExists,
replace)
+
+ case alter: AlterTable => checkAlterTable(alter)
Review comment:
OK. Sounds good. ~~I will also update the migration guide since this is
changing v1 command behavior.~~ (Looks like both will throw
`AnalysisException`, so updating guide is not required, right?)
The reason it's checked here is that `CheckAnalysis` uses `foreachUp`, so
`UnresolvedTableWithViewExists` is handled first before handling `AlterTable`.
Any suggestion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
