hvanhovell commented on a change in pull request #27267:
[WIP][SPARK-30556][SQL] Copy sparkContext.localproperties to child thread
inSubqueryExec.executionContext
URL: https://github.com/apache/spark/pull/27267#discussion_r368616980
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
##########
@@ -749,9 +749,11 @@ case class SubqueryExec(name: String, child: SparkPlan)
private lazy val relationFuture: Future[Array[InternalRow]] = {
// relationFuture is used in "doExecute". Therefore we can get the
execution id correctly here.
val executionId =
sparkContext.getLocalProperty(SQLExecution.EXECUTION_ID_KEY)
+ val localProps = Utils.cloneProperties(sparkContext.getLocalProperties)
Review comment:
Shouldn't we fix this in `SQLExecution.withExecutionId`? That way we can
eliminate the issue you are also trying to fix in
https://github.com/apache/spark/pull/27267.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
