maropu commented on a change in pull request #27231: [SPARK-28478][SQL] Remove redundant null checks URL: https://github.com/apache/spark/pull/27231#discussion_r368783122
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala ########## @@ -35,18 +35,24 @@ class SimplifyConditionalSuite extends PlanTest with PredicateHelper { } protected def assertEquivalent(e1: Expression, e2: Expression): Unit = { - val correctAnswer = Project(Alias(e2, "out")() :: Nil, OneRowRelation()).analyze - val actual = Optimize.execute(Project(Alias(e1, "out")() :: Nil, OneRowRelation()).analyze) + val correctAnswer = Project(Alias(e2, "out")() :: Nil, LocalRelation('a.int)).analyze + val actual = Optimize.execute( + Project(Alias(e1, "out")() :: Nil, LocalRelation('a.int)).analyze) Review comment: nit: you don't need to break this line. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org