maropu commented on a change in pull request #27231: [SPARK-28478][SQL] Remove
redundant null checks
URL: https://github.com/apache/spark/pull/27231#discussion_r368785396
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/SimplifyConditionalSuite.scala
##########
@@ -128,7 +192,7 @@ class SimplifyConditionalSuite extends PlanTest with
PredicateHelper {
// When the conditions in `CaseWhen` are all deterministic, `CaseWhen` can
be removed.
assertEquivalent(
CaseWhen((isNotNullCond, Subtract(Literal(3), Literal(2))) ::
- (isNullCond, Literal(1)) ::
+ (isNullCondB, Literal(1)) ::
Review comment:
You don't need to change the existing tests where possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
