HyukjinKwon commented on a change in pull request #27242: [SPARK-30534][INFRA]
Use mvn in `dev/scalastyle`
URL: https://github.com/apache/spark/pull/27242#discussion_r368838728
##########
File path: dev/scalastyle
##########
@@ -17,18 +17,10 @@
# limitations under the License.
#
-SPARK_PROFILES=${1:-"-Pmesos -Pkubernetes -Pyarn -Pspark-ganglia-lgpl
-Pkinesis-asl -Phive-thriftserver -Phive"}
+SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
-# NOTE: echo "q" is needed because SBT prompts the user for input on
encountering a build file
-# with failure (either resolution or compilation); the "q" makes SBT quit.
-ERRORS=$(echo -e "q\n" \
- | build/sbt \
- ${SPARK_PROFILES} \
- -Pdocker-integration-tests \
- -Pkubernetes-integration-tests \
- scalastyle test:scalastyle \
- | awk '{if($1~/error/)print}' \
-)
+SPARK_PROFILES=${1:-"-Pmesos -Pkubernetes -Pyarn -Pspark-ganglia-lgpl
-Pkinesis-asl -Phive-thriftserver -Phive -Pdocker-integration-tests
-Pkubernetes-integration-tests"}
+ERRORS=$($SCRIPT_DIR/../build/mvn $SPARK_PROFILES scalastyle:check | grep
"^error file")
Review comment:
So, I guess this is a temp fix and we should fix SBT build to use HTTPs
correctly .. am I correct?
If this was a non-temp fix, we should rather have another script like
`lint-java` vs `sbt-checkstyle`. Ideally we should use SBT in PR builder to
save times.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
