HyukjinKwon commented on a change in pull request #27242: [SPARK-30534][INFRA]
Use mvn in `dev/scalastyle`
URL: https://github.com/apache/spark/pull/27242#discussion_r368842656
##########
File path: dev/scalastyle
##########
@@ -17,18 +17,10 @@
# limitations under the License.
#
-SPARK_PROFILES=${1:-"-Pmesos -Pkubernetes -Pyarn -Pspark-ganglia-lgpl
-Pkinesis-asl -Phive-thriftserver -Phive"}
+SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
-# NOTE: echo "q" is needed because SBT prompts the user for input on
encountering a build file
-# with failure (either resolution or compilation); the "q" makes SBT quit.
-ERRORS=$(echo -e "q\n" \
- | build/sbt \
- ${SPARK_PROFILES} \
- -Pdocker-integration-tests \
- -Pkubernetes-integration-tests \
- scalastyle test:scalastyle \
- | awk '{if($1~/error/)print}' \
-)
+SPARK_PROFILES=${1:-"-Pmesos -Pkubernetes -Pyarn -Pspark-ganglia-lgpl
-Pkinesis-asl -Phive-thriftserver -Phive -Pdocker-integration-tests
-Pkubernetes-integration-tests"}
+ERRORS=$($SCRIPT_DIR/../build/mvn $SPARK_PROFILES scalastyle:check | grep
"^error file")
Review comment:
The problem is it affects PR builder:
https://github.com/apache/spark/blob/32af7004a254107340df908e8dd91a0bc22e068e/dev/run-tests.py#L182-L187
and switching to Maven wasn't encouraged in PR builder; so I had to add such
script to use SBT `sbt-checkstyle`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
