viirya commented on a change in pull request #27165: [SPARK-28264][PYTHON][SQL] Support type hints in pandas UDF and rename/move inconsistent pandas UDF types URL: https://github.com/apache/spark/pull/27165#discussion_r368843427
########## File path: python/pyspark/sql/tests/test_pandas_udf_typehints.py ########## @@ -0,0 +1,273 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +import sys +import unittest +import inspect + +from pyspark.sql.functions import mean, lit +from pyspark.testing.sqlutils import ReusedSQLTestCase, \ + have_pandas, have_pyarrow, pandas_requirement_message, \ + pyarrow_requirement_message +from pyspark.sql.pandas.typehints import infer_eval_type +from pyspark.sql.pandas.functions import pandas_udf, PandasUDFType + +if have_pandas: + import pandas as pd + from pandas.util.testing import assert_frame_equal + +python_requirement_message = "pandas UDF with type hints are supported with Python 3.6+." + + +@unittest.skipIf( + not have_pandas or not have_pyarrow or sys.version_info[:2] < (3, 6), + pandas_requirement_message or pyarrow_requirement_message or python_requirement_message) +class PandasUDFTypeHintsTests(ReusedSQLTestCase): + # Note that, we should not remove `exec` once we drop Python 2 in this class. Review comment: Not sure about this. To confirm, does it mean we should not remove `exec` even after we drop Python 2 support? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
