Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/4677#issuecomment-74967548
My recommendations:
* Name the new run() method something more explicit like
runWithValidation().
* Don't add the extra train() methods since users can use run().
* Rename convergenceTol to something like validationTol (since
convergenceTol applies to the training set in general).
* Generalize the boost() method rather than duplicating it to avoid code
duplication.
We had discussed providing a helper method evaluateEachIteration() in the
JIRA, but I'd prefer to have that be a separate JIRA and PR. Does that sound
good?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
