Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/4677#issuecomment-75026265
@jkbradley I have fixed up your comments.
Btw, why are there are both a train and a run, which seems to me do the
same thing. Is it not better to have one way of doing things.
Also a doubt in the case of the Classification problem. It seems to me for
each iteration, the problem is changed explicitly to a Regression problem with
labels mapped to {-1, 1}. Is it okay to break when this regression error no
longer reduces on the validation data for a classification problem (which seems
slightly awkward to me)?
Note that I had to explicitly set it to Regression to make sure that this
test passes,
(https://github.com/apache/spark/pull/4677/files#diff-d3159b88ae0ed6ff096ff8850ecac26eR207)
. Otherwise, the classification error seems to be the same for both with and
without validation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
