zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578460274 @HyukjinKwon > I am all good as long as we can use the latest `testthat`. This is a really annoying and rather critical problem because many R libraries nowsdays has `testthat` dependency. Following @dongjoon-hyun advice I moved commits fixing test issues discovered here out this PR. Could you take a look at https://github.com/apache/spark/pull/27362 and see if it makes sense to you? As of the other one, I'll try to debug this over next few days and see if I can find a fix, if not questions remains if it should be a blocker for testthat upgrade. It feel like a bit like sweeping things under the rug.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
