zero323 commented on issue #27359: [SPARK-23435][SPARKR][TESTS] Update testthat to >= 2.0.0 URL: https://github.com/apache/spark/pull/27359#issuecomment-578461836 > @zero323, so basically you couldn't figure out CRAN check to work with R 3.1.3? If that's the case, does it work with the latest of R 3.4.x (at least in your local or any Linux based OS)? As long as fix for [SPARK-30645](https://issues.apache.org/jira/browse/SPARK-30645) is applied and test for cleanClosure on recursive ([SPARK-30629](https://issues.apache.org/jira/browse/SPARK-30629)) is disabled everything looks green, i.e. - Passes all tests locally on R 3.6.2 / testthat 2.3.1 - It passes all tests on AppVeyor (I don't recall R version there, but testthat is 2.3.1). - On Jenkins we fallback to 1.x so it is not really meaningful (I don't see how SPARK-30629 flies under the radar there), but all tests passed as well. About _I couldn't figure_ ‒ I tried to `install.packages` inside `R/pkg/tests/run-all.R` in different combinations that seem to work locally, but it failed miserably on Jenkins (in general with R 3.1 used there we can target only `testthat` 2.0 or so, as later versions require 0.4, which in turn depends on R >= 3.2).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
