tgravescs commented on a change in pull request #26682: [SPARK-29306][CORE]
Stage Level Sched: Executors need to track what ResourceProfile they are
created with
URL: https://github.com/apache/spark/pull/26682#discussion_r371318137
##########
File path:
core/src/main/scala/org/apache/spark/resource/ExecutorResourceRequests.scala
##########
@@ -32,9 +34,9 @@ import org.apache.spark.resource.ResourceProfile._
*/
private[spark] class ExecutorResourceRequests() extends Serializable {
- private val _executorResources = new mutable.HashMap[String,
ExecutorResourceRequest]()
+ private val _executorResources = new ConcurrentHashMap[String,
ExecutorResourceRequest]()
Review comment:
it's for correctness. to allow users to manipulate the
ExecutorResourceRequests multiple times. The original intent was all of these
classes would be immutable, but that made things less user friendly so in the
original PR this class got created and users are allowed to modify multiple
times and they could do it from multiple threads. It's something I missed in
the original pr rework.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
