tgravescs commented on a change in pull request #26682: [SPARK-29306][CORE]
Stage Level Sched: Executors need to track what ResourceProfile they are
created with
URL: https://github.com/apache/spark/pull/26682#discussion_r371353605
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
##########
@@ -392,8 +418,26 @@ private[spark] class ExecutorMonitor(
* which the `SparkListenerTaskStart` event is posted before the
`SparkListenerBlockManagerAdded`
* event, which is possible because these events are posted in different
threads. (see SPARK-4951)
*/
- private def ensureExecutorIsTracked(id: String): Tracker = {
- executors.computeIfAbsent(id, _ => new Tracker())
+ private def ensureExecutorIsTracked(id: String, resourceProfileId: Int):
Tracker = {
+ val numExecsWithRpId =
execResourceProfileCount.computeIfAbsent(resourceProfileId, _ => 0)
+ val execTracker = executors.computeIfAbsent(id, _ => {
+ val newcount = numExecsWithRpId + 1
+ execResourceProfileCount.put(resourceProfileId, newcount)
+ logDebug(s"Executor added with ResourceProfile id: $resourceProfileId
" +
+ s"count is now $newcount")
+ new Tracker(resourceProfileId)
+ })
Review comment:
so that shouldn't happen to execResourceProfileCount because all of the
calls to modify it are from the event listener which is single threaded. There
is a call to get that can happen from separate threads but that won't affect
the modify case. We update both executors and execResourceProfileCount at the
same time on adding and removing so those should be in lock step.
I think I can change them to compute if it makes it easier to read?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
