tgravescs commented on a change in pull request #26682: [SPARK-29306][CORE]
Stage Level Sched: Executors need to track what ResourceProfile they are
created with
URL: https://github.com/apache/spark/pull/26682#discussion_r371516044
##########
File path:
core/src/main/scala/org/apache/spark/resource/ExecutorResourceRequest.scala
##########
@@ -63,15 +56,21 @@ private[spark] class ExecutorResourceRequest(
val discoveryScript: String = "",
Review comment:
yes should be able to. I wasn't sure if the Scala side would get annoyed
with having to use java object as parameter, or more so that spark had any
api's that did that. Maybe what I'll do is change ExecutorResourceRequest which
I don't expect the user to wield directly as much to Optional and then provide
2 different resource() api's here, one that take java Optional and one that
takes the scala Option and convert to Optional before creating the
ExecutorResourceRequest, just as a convenience thing for scala users.
thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
