srowen commented on a change in pull request #27374: [SPARK-30659][ML][PYSPARK]
LogisticRegression blockify input vectors
URL: https://github.com/apache/spark/pull/27374#discussion_r371845146
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/LogisticAggregator.scala
##########
@@ -209,6 +208,70 @@ private[ml] class LogisticAggregator(
s"got type ${bcCoefficients.value.getClass}.)")
}
+ // Helper vectors and matrices for binary:
+ @transient private lazy val binaryLinear = {
Review comment:
So, are these lazy just to deal with recreating them after deserialization?
they don't seem big, so can they just be non-transient, non-lazy? unless it's a
material problem, might be simpler and faster.
Or how much do you need to hold on to scratch vectors like auxiliaryVec vs
just locals?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
