srowen commented on a change in pull request #27374: [SPARK-30659][ML][PYSPARK]
LogisticRegression blockify input vectors
URL: https://github.com/apache/spark/pull/27374#discussion_r371846339
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/optim/aggregator/LogisticAggregatorSuite.scala
##########
@@ -32,21 +32,21 @@ class LogisticAggregatorSuite extends SparkFunSuite with
MLlibTestSparkContext {
override def beforeAll(): Unit = {
super.beforeAll()
- instances = Array(
+ instances = standardize(Array(
Review comment:
Just curious, why do these have to be standardized now?
One thing I want to be careful about is not introducing bugs of course, and
so having it pass existing tests as-is is a good indicator that it doesn't.
This may be fine but are we changing inputs to match old outputs - did behavior
change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
