Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3629#discussion_r25046324
--- Diff: core/src/main/scala/org/apache/spark/storage/MemoryStore.scala ---
@@ -328,6 +330,7 @@ private[spark] class MemoryStore(blockManager:
BlockManager, maxMemory: Long)
val droppedBlocks = new ArrayBuffer[(BlockId, BlockStatus)]
accountingLock.synchronized {
+ releasePendingUnrollMemoryForThisThread()
--- End diff --
as commented in the main thread, I would move this to the end of this
`accountingLock.synchronized` block and add a comment there:
```
// Release the memory used to unroll this block
// because we no longer need the underlying Array
releasePendingUnrollMemoryForThisThread()
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
