zhengruifeng commented on a change in pull request #27389:
[SPARK-30662][ML][PySpark] ALS/MLP extend HasBlockSize
URL: https://github.com/apache/spark/pull/27389#discussion_r372751361
##########
File path:
mllib/src/main/scala/org/apache/spark/ml/classification/MultilayerPerceptronClassifier.scala
##########
@@ -54,26 +54,6 @@ private[classification] trait MultilayerPerceptronParams
extends ProbabilisticCl
@Since("1.5.0")
final def getLayers: Array[Int] = $(layers)
- /**
- * Block size for stacking input data in matrices to speed up the
computation.
- * Data is stacked within partitions. If block size is more than remaining
data in
- * a partition then it is adjusted to the size of this data.
- * Recommended size is between 10 and 1000.
- * Default: 128
- *
- * @group expertParam
- */
- @Since("1.5.0")
- final val blockSize: IntParam = new IntParam(this, "blockSize",
- "Block size for stacking input data in matrices. Data is stacked within
partitions." +
- " If block size is more than remaining data in a partition then " +
- "it is adjusted to the size of this data. Recommended size is between 10
and 1000",
- ParamValidators.gt(0))
-
- /** @group expertGetParam */
- @Since("1.5.0")
- final def getBlockSize: Int = $(blockSize)
Review comment:
The default value of blocksize in MLP is 128, so explicitly
`setDefault(blockSize -> 128)` in MLP?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
