viirya commented on a change in pull request #27389: [SPARK-30662][ML][PySpark]
ALS/MLP extend HasBlockSize
URL: https://github.com/apache/spark/pull/27389#discussion_r372766172
##########
File path: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
##########
@@ -483,7 +494,6 @@ class ALSModel private[ml] (
/**
* Blockifies factors to improve the efficiency of cross join
- * TODO: SPARK-20443 - expose blockSize as a param?
*/
private def blockify(
factors: Dataset[(Int, Array[Float])],
Review comment:
Do we still need default blockSize in this method? i.e.,`blockSize: Int =
4096`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
