Github user MechCoder commented on the pull request:
https://github.com/apache/spark/pull/4677#issuecomment-75195111
@jkbradley I've fixed up your comments.
a] Negative tol is allowed.
b] It makes sense to return based on the best validationError rather than
the previous one (when it breaks) so I've changed that too.
c] I've added a section to ensembles so that this can be easily found.
I think we are ready for a final round of reviews.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
