HeartSaVioR commented on a change in pull request #27408:
[SPARK-30481][CORE][FOLLOWUP] Execute log compaction only when merge
application listing is successful
URL: https://github.com/apache/spark/pull/27408#discussion_r373279084
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -834,6 +839,8 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
case None => // This is not applied to single event log file.
}
+ } catch {
+ case e: Exception => logError(s"Exception while compacting log for
$rootPath", e)
Review comment:
That's consistent with existing exception handling for
`mergeApplicationListing`.
https://github.com/apache/spark/blob/5916c7d0d0a68266ede1b7e54c3498a18142cf8f/core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala#L654-L690
`compact` is even executed only when `mergeApplicationListing` succeeds,
which would prune many of possible error cases for `compact`, so less possible
to be logged.
If we feel the log level of both are too high, I'll change both altogether.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
