dongjoon-hyun commented on a change in pull request #27408:
[SPARK-30481][CORE][FOLLOWUP] Execute log compaction only when merge
application listing is successful
URL: https://github.com/apache/spark/pull/27408#discussion_r373280676
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -834,6 +839,8 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
case None => // This is not applied to single event log file.
}
+ } catch {
+ case e: Exception => logError(s"Exception while compacting log for
$rootPath", e)
Review comment:
The above error handling is more fine-grained that this.
For example, `AccessControlException` is the one which most users will hit
frequently with this feature. (That's the reason why I asked at the
documentation.) For `AccessControlException`, the above code shows `logWarning`
instead of `logError`. That seems to be the difference between your and my
perspectives.
Let's see @vanzin or other people's opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
