Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/4027#issuecomment-75314717
  
    Hi @tnachen this looks like a reasonably straight-forward change. My inline 
comments have mostly to do with naming and docs. One high level question: does 
it make sense to set the max executors per slave but *not* the max cores per 
executor? For instance, if I allow 3 executors per slave but I don't control 
the number of cores each executor uses, then the first one will just gladly 
grab all the cores on that slave, right? Do we need to enforce some kind of 
constraint between these two configs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to