Github user CodingCat commented on a diff in the pull request:
https://github.com/apache/spark/pull/4027#discussion_r25138542
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -204,35 +209,43 @@ private[spark] class CoarseMesosSchedulerBackend(
for (offer <- offers) {
val slaveId = offer.getSlaveId.toString
- val mem = getResource(offer.getResourcesList, "mem")
- val cpus = getResource(offer.getResourcesList, "cpus").toInt
- if (totalCoresAcquired < maxCores &&
- mem >= MemoryUtils.calculateTotalMemory(sc) &&
- cpus >= 1 &&
+ var totalMem = getResource(offer.getResourcesList, "mem")
+ var totalCpus = getResource(offer.getResourcesList, "cpus").toInt
--- End diff --
since he changed the value of "offerCores" when some of the cores are
allocated....a better name might be âleftCoresInOfferâ ?
same for the memory
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
