Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4690#discussion_r25101678
--- Diff: core/src/main/scala/org/apache/spark/rdd/NewHadoopRDD.scala ---
@@ -174,11 +174,8 @@ class NewHadoopRDD[K, V](
}
}
} catch {
- case e: Exception => {
- if (!Utils.inShutdown()) {
- logWarning("Exception in RecordReader.close()", e)
- }
- }
+ case e: Exception =>
+ logWarning("Exception in RecordReader.close()", e)
--- End diff --
Ah sorry, I mean revert. Although I kind of like the additional follow-on
changes, for this PR we should foremost focus on patching up the exception. If
there's any question about any extra changes, like the one you raised, I'd
favor just reverting that part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
