Github user nishkamravi2 commented on the pull request:

    https://github.com/apache/spark/pull/4690#issuecomment-75337749
  
    @srowen @andrewor14  I can potentially issue a different PR for the 
performance issue and back it out from here (it does seem somewhat unrelated). 
In general, I would vote for discouraging use of this function. Code patterns 
like these tend to spread-- one could argue checking this condition on several 
other exit paths in Spark? Also, do we know that if we delete the check we 
would see noisy stack traces or are we just being careful speculatively? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to