jiangxb1987 commented on a change in pull request #27395: [SPARK-30667][CORE]
Add allGather method to BarrierTaskContext
URL: https://github.com/apache/spark/pull/27395#discussion_r373730757
##########
File path: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala
##########
@@ -118,13 +84,15 @@ class BarrierTaskContext private[spark] (
// Log the update of global sync every 60 seconds.
timer.schedule(timerTask, 60000, 60000)
+ var messagesSerialized: Array[Byte] = Array[Byte]()
+
try {
- val abortableRpcFuture = barrierCoordinator.askAbortable[Unit](
+ val abortableRpcFuture = barrierCoordinator.askAbortable[Array[Byte]](
message = RequestToSync(numTasks, stageId, stageAttemptNumber,
taskAttemptId,
- barrierEpoch),
+ barrierEpoch, requestMethod, allGatherMessage),
// Set a fixed timeout for RPC here, so users shall get a
SparkException thrown by
// BarrierCoordinator on timeout, instead of RPCTimeoutException from
the RPC framework.
- timeout = new RpcTimeout(365.days, "barrierTimeout"))
+ timeout = new RpcTimeout(31536000 /* = 3600 * 24 * 365 */ seconds,
"barrierTimeout"))
Review comment:
Why is this change necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
