jiangxb1987 commented on a change in pull request #27395: [SPARK-30667][CORE]
Add allGather method to BarrierTaskContext
URL: https://github.com/apache/spark/pull/27395#discussion_r373729930
##########
File path: core/src/main/scala/org/apache/spark/BarrierCoordinator.scala
##########
@@ -99,9 +101,13 @@ private[spark] class BarrierCoordinator(
// reset when a barrier() call fails due to timeout.
private var barrierEpoch: Int = 0
- // An array of RPCCallContexts for barrier tasks that are waiting for
reply of a barrier()
- // call.
+ // Arrays of RPCCallContexts and RequestToSyncs for barrier tasks that
have made a blocking
+ // runBarrier() call
private val requesters: ArrayBuffer[RpcCallContext] = new
ArrayBuffer[RpcCallContext](numTasks)
+ private val requests: ArrayBuffer[RequestToSync] = new
ArrayBuffer[RequestToSync](numTasks)
+
+ // The blocking requestMethod called by tasks to sync up for this stage
attempt
+ private var requestMethodToSync: Int = 0
Review comment:
Might want to use MessageType instead of Int?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
