Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4214#discussion_r25109254
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -73,27 +103,15 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
private[history] val APPLICATION_COMPLETE = "APPLICATION_COMPLETE"
/**
- * A background thread that periodically checks for event log updates on
disk.
- *
- * If a log check is invoked manually in the middle of a period, this
thread re-adjusts the
- * time at which it performs the next log check to maintain the same
period as before.
- *
- * TODO: Add a mechanism to update manually.
+ * A background thread that periodically do something about event log.
--- End diff --
this comment is super vague! How about
```
/**
* Return a runnable that performs the given operation on the event logs.
* This operation is expected to be executed periodically.
*/
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
