Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4214#discussion_r25109543
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -53,8 +81,10 @@ private[history] class FsHistoryProvider(conf: 
SparkConf) extends ApplicationHis
     
       private val fs = Utils.getHadoopFileSystem(logDir, 
SparkHadoopUtil.get.newConfiguration(conf))
     
    -  // A timestamp of when the disk was last accessed to check for log 
updates
    -  private var lastLogCheckTimeMs = -1L
    +  // Scheduled thread pool size must be one, otherwise it will have 
concurrent issues about fs
    +  // and applications between check task and clean task.
    +  private val pool = Executors.newScheduledThreadPool(1, new 
ThreadFactoryBuilder()
    --- End diff --
    
    how about some comment on what this pool is used for


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to