imback82 commented on a change in pull request #27444: [SPARK-30614][SQL] The
native ALTER COLUMN syntax should change one property at a time
URL: https://github.com/apache/spark/pull/27444#discussion_r375071833
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -92,17 +88,27 @@ class ResolveSessionCatalog(
val builder = new MetadataBuilder
// Add comment to metadata
a.comment.map(c => builder.putString("comment", c))
+ val colName = a.column(0)
+ val dataType = a.dataType.getOrElse {
+ v1Table.schema.findNestedField(Seq(colName), resolver =
conf.resolver)
+ .map(_._2.dataType)
+ .getOrElse {
+ throw new AnalysisException(
+ s"ALTER COLUMN cannot find column ${quote(colName)} in v1
table. " +
+ s"Available: ${v1Table.schema.fieldNames.mkString(", ")}")
+ }
+ }
// Add Hive type string to metadata.
- val cleanedDataType = HiveStringType.replaceCharType(a.dataType.get)
- if (a.dataType.get != cleanedDataType) {
+ val cleanedDataType = HiveStringType.replaceCharType(dataType)
+ if (dataType != cleanedDataType) {
builder.putString(HIVE_TYPE_STRING, a.dataType.get.catalogString)
}
Review comment:
good catch. it should be `builder.putString(HIVE_TYPE_STRING,
dataType.catalogString)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
