HyukjinKwon commented on a change in pull request #27459:
[SPARK-30510][SQL][DOCS] Publicly document Spark SQL configuration options
URL: https://github.com/apache/spark/pull/27459#discussion_r375681936
##########
File path: sql/gen-sql-markdown.py
##########
@@ -47,6 +53,18 @@ def _list_function_infos(jvm):
return sorted(infos, key=lambda i: i.name)
+def _list_sql_configs(jvm):
+ sql_configs = [
+ SQLConfEntry(
+ name=_sql_config._1(),
+ default=_sql_config._2(),
Review comment:
Okay `67108864b` isn't actually particularly wrong. It just converted bytes
configuration to string byte representation. I think we should the default
value to strings so that it doesn't get into byte string representation. For
example,
```diff
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
@@ -1013,7 +1013,7 @@ object SQLConf {
"This configuration is effective only when using file-based sources
such as Parquet, JSON " +
"and ORC.")
.bytesConf(ByteUnit.BYTE)
- .createWithDefault(128 * 1024 * 1024) // parquet.block.size
+ .createWithDefaultString("128MB") // parquet.block.size
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
