HyukjinKwon commented on a change in pull request #27459:
[SPARK-30510][SQL][DOCS] Publicly document Spark SQL configuration options
URL: https://github.com/apache/spark/pull/27459#discussion_r375685354
##########
File path: sql/gen-sql-markdown.py
##########
@@ -15,12 +15,18 @@
# limitations under the License.
#
-import sys
import os
+import re
+import sys
from collections import namedtuple
+from textwrap import dedent
+
+from mkdocs.structure.pages import markdown
ExpressionInfo = namedtuple(
"ExpressionInfo", "className name usage arguments examples note since
deprecated")
+SQLConfEntry = namedtuple(
+ "SQLConfEntry", ["name", "default", "docstring"])
Review comment:
I would rename `docstring` to something like `documentation` or
`description`. docstring is a python term I believe :-).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
