Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/4708#issuecomment-75494807
  
    I took a quick pass, but overall this looks pretty good to me since it's 
inline with the refactoring that I had originally planned to do myself.  It's 
nice to see a lot of the weird `isShuffleMap` stuff removed.  I also like how 
this refactoring clarifies that ShuffleMapTasks always belong to 
ShuffleMapStages, etc.
    
    Maybe @markhamstra or @kayousterhout would like to take a look at this?  
This looks like a pretty straightforward, low-risk refactoring to me, but it 
would be good to get more eyes on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to