Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4708#discussion_r25188257
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -228,22 +227,41 @@ class DAGScheduler(
       }
     
       /**
    -   * Create a Stage -- either directly for use as a result stage, or as 
part of the (re)-creation
    -   * of a shuffle map stage in newOrUsedStage.  The stage will be 
associated with the provided
    -   * jobId. Production of shuffle map stages should always use 
newOrUsedStage, not newStage
    -   * directly.
    +   * Create a ShuffleMapStage as part of the (re)-creation of a shuffle 
map stage in 
    +   * newOrUsedShuffleStage.  The stage will be associated with the provided
    +   * jobId. Production of shuffle map stages should always use 
newOrUsedShuffleStage, 
    +   * not newShuffleMapStage directly.
    --- End diff --
    
    nit: reformat a little...
    ```scala
      /**
       * Create a ShuffleMapStage as part of the (re)-creation of a shuffle map 
stage in 
       * newOrUsedShuffleStage.  The stage will be associated with the provided 
jobId.
       * Production of shuffle map stages should always use 
newOrUsedShuffleStage, not
       * newShuffleMapStage directly.
       */
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to