cloud-fan commented on a change in pull request #27368: [SPARK-30651][SQL] Add
detailed information for Aggregate operators in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/27368#discussion_r375706549
##########
File path: sql/core/src/test/resources/sql-tests/results/explain.sql.out
##########
@@ -523,12 +571,20 @@ Input : [key#x, val#x]
(8) HashAggregate [codegen id : 1]
Input: [key#x]
+Keys: []
+Functions: [partial_max(key#x)]
+Results: [max#x]
Review comment:
This is hard to read because `max` is a buffer attribute. I think we should
also print all the buffer attributes.
We can get it by `HashAggregateExec.aggregateBufferAttributes`
Let's also test `avg` which has 2 buffer attributes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
