cloud-fan commented on a change in pull request #27368: [SPARK-30651][SQL] Add
detailed information for Aggregate operators in EXPLAIN FORMATTED
URL: https://github.com/apache/spark/pull/27368#discussion_r375835290
##########
File path: sql/core/src/test/resources/sql-tests/results/explain.sql.out
##########
@@ -76,12 +84,20 @@ Input : [key#x, val#x]
(5) HashAggregate [codegen id : 1]
Input: [key#x, val#x]
+Keys: [key#x]
+Functions: [partial_max(val#x)]
+FuncBufferAttrs: [max#x]
+Results: [key#x, max#x]
(6) Exchange
Input: [key#x, max#x]
(7) HashAggregate [codegen id : 2]
Input: [key#x, max#x]
+Keys: [key#x]
+Functions: [max(val#x)]
+FuncBufferAttrs: [max#x]
+Results: [key#x, max(val#x)#x AS max(val)#x]
Review comment:
Sorry I was wrong. I checked the source code again. The result expressions
depend on `HashAggregate.aggregateAttributes`. For partial aggregate, it's the
buffer attributes, but for final aggregate, it's not.
Let's show `Aggregate Attributes` instead of `FuncBufferAttrs`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
