tgravescs commented on a change in pull request #27207:
[WIP][SPARK-18886][CORE] Make Locality wait time measure resource under
utilization due to delay scheduling.
URL: https://github.com/apache/spark/pull/27207#discussion_r376094582
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -469,8 +486,10 @@ private[spark] class TaskSetManager(
extraResources,
serializedTask)
}
+ (taskDescription,
+ taskDescription.isEmpty && maxLocality == TaskLocality.ANY &&
pendingTasks.all.nonEmpty)
Review comment:
actually that reminds me of speculative tasks and we need to account for
those.
I don't think it hurts to taskDescription.isEmpty means no task was assigned.
if you move it down, it can't be an else if though it would just be a
separate if before None is returned. It might make a little more sense down in
dequeueTask because its dealing with the localities and choosing which
pendingTasks to look at.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
