sarutak commented on a change in pull request #27490: [SPARK-30753][WEBUI]
Remove unnecessary changes in SPARK-30684
URL: https://github.com/apache/spark/pull/27490#discussion_r376502477
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala
##########
@@ -202,8 +197,8 @@ private[ui] class SparkPlanGraphCluster(
val labelStr = if (duration.nonEmpty) {
require(duration.length == 1)
val id = duration(0).accumulatorId
- if (metricsValue.contains(id)) {
- name + "\n \n" + duration(0).name + ": " + metricsValue(id)
+ if (metricsValue.contains(duration(0).accumulatorId)) {
Review comment:
Please keep `metricsBalue.contains(id)` as is. Let's avoid calling
`duration(0).accumulatorId` twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
