sarutak commented on a change in pull request #27490: [SPARK-30753][WEBUI]
Remove unnecessary changes in SPARK-30684
URL: https://github.com/apache/spark/pull/27490#discussion_r376506646
##########
File path:
sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.js
##########
@@ -82,7 +81,7 @@ function setupTooltipForSparkPlanNode(nodeId) {
* and sizes of graph elements, e.g. padding, font style, shape.
*/
function preprocessGraphLayout(g) {
- g.graph().ranksep = "90";
+ g.graph().ranksep = "70";
Review comment:
A gap between an arrow and a node in a whole-stage-codegen node seems to be
broader than before (e.g. SerializeFromObject and its forwarding arrow in the
screenshot).
It's a little bit ugly so I think it's better to narrow those gaps if you
can.
I wanted to insert a blank line between `WholeStageCodegen(#)` and its
metrics description like other operator nodes so I proposed that change.
But I don't have strong opinion to insert a blank line if there is no way to
keep the code simple.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
