mridulm commented on a change in pull request #27313: [SPARK-29148][CORE] Add
stage level scheduling dynamic allocation and scheduler backend changes
URL: https://github.com/apache/spark/pull/27313#discussion_r376763195
##########
File path: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala
##########
@@ -726,14 +894,23 @@ private[spark] class ExecutorAllocationManager(
})
}
- registerGauge("numberExecutorsToAdd", numExecutorsToAdd, 0)
+ // The metrics are going to return the numbers for the default
ResourceProfile.
+ // It would be nice to do include each profile somehow in the future.
Review comment:
Did we ever explicitly document what numberExecutorsToAdd means ? I did not
see it in our doc, but I could have missed it - if we did document it, adhering
to what that means would be ideal.
Assuming not, intutively I would expect it to be total outstanding requests.
Without resource profiles, default == total, so no behavior change; but with
resource profile, I would have expected numberExecutorsToAdd to mean total with
a resourceProfile.<rpId>.numberExecutorsToAdd (or some such naming) to give
individual values per profile. Thoughts ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
