mridulm commented on a change in pull request #27313: [SPARK-29148][CORE] Add
stage level scheduling dynamic allocation and scheduler backend changes
URL: https://github.com/apache/spark/pull/27313#discussion_r376763617
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##########
@@ -69,27 +69,17 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
conf.get(SCHEDULER_MAX_REGISTERED_RESOURCE_WAITING_TIME))
private val createTimeNs = System.nanoTime()
- private val taskResourceNumParts: Map[String, Int] =
- if (scheduler.resourcesReqsPerTask != null) {
- scheduler.resourcesReqsPerTask.map(req => req.resourceName ->
req.numParts).toMap
- } else {
- Map.empty
- }
-
// Accessing `executorDataMap` in the inherited methods from
ThreadSafeRpcEndpoint doesn't need
// any protection. But accessing `executorDataMap` out of the inherited
methods must be
// protected by `CoarseGrainedSchedulerBackend.this`. Besides,
`executorDataMap` should only
// be modified in the inherited methods from ThreadSafeRpcEndpoint with
protection by
// `CoarseGrainedSchedulerBackend.this`.
private val executorDataMap = new HashMap[String, ExecutorData]
- // Number of executors requested by the cluster manager,
[[ExecutorAllocationManager]]
- @GuardedBy("CoarseGrainedSchedulerBackend.this")
- private var requestedTotalExecutors = 0
-
- // Number of executors requested from the cluster manager that have not
registered yet
+ // Number of executors for each ResourceProfile requested by the cluster
+ // manager, [[ExecutorAllocationManager]]
@GuardedBy("CoarseGrainedSchedulerBackend.this")
- private var numPendingExecutors = 0
Review comment:
Yes, for logging. If the code paths that logging was to help debug are no
longer relevant (some past bugs which have been fixed subsequently with dead
code lying around, for example) - then it makes sense to remove it.
Looking at history, this is a fairly old change by @rdblue (#17813) - which
changed use of numPendingExecutors from being functional to purely logging.
Perhaps you are right, time to remove it !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
