zhengruifeng commented on a change in pull request #27461: [SPARK-30736][ML]
One-Pass ChiSquareTest
URL: https://github.com/apache/spark/pull/27461#discussion_r376919892
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/stat/ChiSquareTestSuite.scala
##########
@@ -53,6 +53,20 @@ class ChiSquareTestSuite
assert(degreesOfFreedom === Array(2, 3))
assert(statistics ~== Vectors.dense(0.75, 1.5) relTol 1e-4)
}
+
+ val sparseData = data.map { case LabeledPoint(label, features) =>
Review comment:
I am OK to add a test case for this. But I am not very sure whether we
should add this method for sparse dataset. Maybe the input is supposed to be
dense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
