zhengruifeng commented on a change in pull request #27461: [SPARK-30736][ML]
One-Pass ChiSquareTest
URL: https://github.com/apache/spark/pull/27461#discussion_r377429465
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/stat/ChiSquareTestSuite.scala
##########
@@ -53,6 +53,20 @@ class ChiSquareTestSuite
assert(degreesOfFreedom === Array(2, 3))
assert(statistics ~== Vectors.dense(0.75, 1.5) relTol 1e-4)
}
+
+ val sparseData = data.map { case LabeledPoint(label, features) =>
Review comment:
OK, I will add new testsuites for sparse input, sepecially for dataset
containing column that only have zero vaues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
