cloud-fan commented on a change in pull request #27494: [SPARK-30760][SQL] Port
`millisToDays` and `daysToMillis` on Java 8 time API
URL: https://github.com/apache/spark/pull/27494#discussion_r376978518
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -337,6 +337,7 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true)
case _ =>
}
+ localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true)
Review comment:
I think this is a bug in `HiveResult`, not just this test suite.
When we produce string result, we must stick with the Proleptic Gregorian
calendar and call `LocalDate/Instant.toString`. I think we should update
`HiveResult.hiveResultString` and enable java 8 datetime API before calling
`collect`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
