beliefer commented on a change in pull request #27440: [SPARK-27951][SQL]
Support ANSI SQL NTH_VALUE window function
URL: https://github.com/apache/spark/pull/27440#discussion_r377539183
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -363,6 +363,11 @@ abstract class OffsetWindowFunction
*/
val direction: SortDirection
+ /**
+ * Whether the offset is based on the entire frame.
+ */
+ val isWholeBased: Boolean = false
Review comment:
`FIRST` and `LAST` is aggregate function, there were PRs who used them as
`FIRST_VALUE/LAST_VALUE`.
You can reference https://github.com/apache/spark/pull/25082.
All of LEAD/LAG/NTH_VALUE/FIRST_VALUE/LAST_VALUE need `IGNORE NULLS`, I
think we should handle in a consistent way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
