beliefer commented on a change in pull request #27440: [SPARK-27951][SQL]
Support ANSI SQL NTH_VALUE window function
URL: https://github.com/apache/spark/pull/27440#discussion_r377543013
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
##########
@@ -363,6 +363,11 @@ abstract class OffsetWindowFunction
*/
val direction: SortDirection
+ /**
+ * Whether the offset is based on the entire frame.
+ */
+ val isWholeBased: Boolean = false
Review comment:
`LEAD/LAG` not support `IGNORE NULLS` now. Maybe the current implement only
considered `postgreSQL`. So I think as long as
`NTH_VALUE/FIRST_VALUE/LAST_VALUE` use the same way as `LEAD/LAG`, once the
time is right, we can uniformly provide them with support for `IGNORE NULLS`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
