beliefer commented on a change in pull request #27495: [SPARK-28880][SQL]
Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378606843
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
##########
@@ -55,6 +55,65 @@ class PlanParserSuite extends AnalysisTest {
With(plan, ctes)
}
+ test("single comment") {
+ val plan = table("a").select(star())
+ assertEqual("-- single comment\nSELECT * FROM a", plan)
+ }
+
+ test("bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This is an example of SQL which should not execute:
+ | * select 'multi-line';
+ | */
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("bracketed comment case two") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/*
+ |SELECT 'trailing' as x1; -- inside block comment
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case one") {
+ val plan = table("a").select(star())
+ assertEqual(
+ """
+ |/* This block comment surrounds a query which itself has a block
comment...
+ |SELECT /* embedded single line */ 'embedded' AS x2;
+ |*/
+ |SELECT * FROM a
+ """.stripMargin, plan)
+ }
+
+ test("nexted bracketed comment case two") {
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
