beliefer commented on a change in pull request #27495: [SPARK-28880][SQL] 
Support ANSI nested bracketed comments
URL: https://github.com/apache/spark/pull/27495#discussion_r378611241
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/comments.sql
 ##########
 @@ -0,0 +1,70 @@
+-- Test comments.
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated 
golden files
+-- bracketed comment case one
+/* This is the first example of bracketed comment.
+SELECT 'ommented out content' AS first;
+*/
+SELECT 'selected content' AS first;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated 
golden files
+-- bracketed comment case two
+/* This is the second example of bracketed comment.
+SELECT '/', 'ommented out content' AS second;
+*/
+SELECT '/', 'selected content' AS second;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated 
golden files
+-- bracketed comment case three
+/* This is the third example of bracketed comment.
+ *SELECT '*', 'ommented out content' AS third;
+ */
+SELECT '*', 'selected content' AS third;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated 
golden files
+-- nested bracketed comment case one
+/* This is the first example of nested bracketed comment.
+/* I am a nested bracketed comment.*/
+*/
+SELECT 'selected content' AS four;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated 
golden files
+-- nested bracketed comment case two
+/* This is the second example of nested bracketed comment.
+/* I am a nested bracketed comment.
+ */
+ */
+SELECT 'selected content' AS five;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated 
golden files
+-- nested bracketed comment case three
+/*
+ * This is the third example of nested bracketed comment.
+  /*
+   * I am a nested bracketed comment.
+   */
+ */
+SELECT 'selected content' AS six;
+
+-- [SPARK-30758] Spark SQL can't display bracketed comments well in generated 
golden files
+-- nested bracketed comment case four
+/* 
+ * This is the four example of nested bracketed comment.
 
 Review comment:
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to