HyukjinKwon commented on a change in pull request #27575: [SPARK-30827][DOCS]
Document direct relationship among configurations in "spark.history.*" namespace
URL: https://github.com/apache/spark/pull/27575#discussion_r379338701
##########
File path: docs/monitoring.md
##########
@@ -159,22 +159,22 @@ Security options for the Spark History Server are
covered more detail in the
<td>false</td>
<td>
Indicates whether the history server should use kerberos to login. This
is required
- if the history server is accessing HDFS files on a secure Hadoop
cluster. If this is
- true, it uses the configs <code>spark.history.kerberos.principal</code>
and
- <code>spark.history.kerberos.keytab</code>.
+ if the history server is accessing HDFS files on a secure Hadoop cluster.
</td>
</tr>
<tr>
<td>spark.history.kerberos.principal</td>
<td>(none)</td>
<td>
+ Precondition: <code>spark.history.kerberos.enabled=true</code><br/><br/>
Review comment:
@HeartSaVioR, seems `Precondition: ` is new style. Can we follow one
prevailing style we use in the current code base? Or I actually think it's just
better to say "it's effective when spark.xx.xx is enabled." at the end of each
description. Current one seems catching too much attention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
